rephrase and correct the descriptions for clSetKernelExecInfo #1245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Depending how we resolve #1244 we may need to make additional clarifications. |
|
Converting to draft to work out system SVM updates. |
clarify that CL_KERNEL_EXEC_INFO_SVM_FINE_GRAIN_SYSTEM does not affect kernel arguments
|
This is ready for review again. |
bashbaug
commented
Sep 4, 2024
karolherbst
reviewed
Sep 14, 2024
30 tasks
|
Merging (offline) as discussed in the October 22nd teleconference. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1152
fixes #1244
Rephrases and corrects the descriptions for multiple parts of clSetKernelExecInfo.
Removes the cumbersome "note" below the API description and moves the content into the API description instead. I don't think I lost any important content, but this would be a good area for a careful review.
Explicitly states that an empty set of SVM pointers for CL_KERNEL_EXEC_INFO_SVM_PTRS is valid.